Skip to content

schedule/feeds: make json feed schema compatible #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

schedule/feeds: make json feed schema compatible #1612

wants to merge 21 commits into from

Conversation

Kunsi
Copy link
Contributor

@Kunsi Kunsi commented May 24, 2024

No description provided.

@Kunsi Kunsi force-pushed the kunsi-schedule-json-schema-compatible branch 2 times, most recently from d94e2f3 to d70ab38 Compare May 24, 2024 10:51
@Kunsi Kunsi marked this pull request as ready for review May 24, 2024 11:03
Kunsi
Kunsi commented May 24, 2024
View reviewed changes
Kunsi
Kunsi commented Jun 12, 2024
View reviewed changes
marksteward
marksteward requested changes Aug 14, 2024
View reviewed changes
@Kunsi Kunsi force-pushed the kunsi-schedule-json-schema-compatible branch from 174dd59 to 550b857 Compare August 14, 2024 15:30
@Kunsi Kunsi marked this pull request as draft August 14, 2024 16:54
@Kunsi Kunsi force-pushed the kunsi-schedule-json-schema-compatible branch 4 times, most recently from ee12ce8 to c2e1603 Compare August 14, 2024 17:01
@Kunsi
Copy link
Contributor Author

Kunsi commented Aug 14, 2024

I re-set this to draft state because the machine i used to test this on is no longer available, and i don't have any other machines running docker atm

@Kunsi Kunsi force-pushed the kunsi-schedule-json-schema-compatible branch from e8ee349 to d41b13b Compare August 14, 2024 18:23
Kunsi
Kunsi commented Aug 14, 2024
View reviewed changes
@Kunsi Kunsi marked this pull request as ready for review August 31, 2024 12:25
@Kunsi
Copy link
Contributor Author

Kunsi commented Aug 31, 2024

Screenshot 2024-08-31 at 14-25-02
Tested, works.

wlcx
wlcx requested changes Aug 31, 2024
View reviewed changes
Copy link
Member

@wlcx wlcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good inclusion I think, thanks!

I wonder if we should be generating the data for this in one place though, given this is all the same stuff that's in the frab xml exporter. Removes the possiblity of accidentally having the two not agree!

@Kunsi Kunsi requested review from marksteward and wlcx May 29, 2025 15:14
@Kunsi
Copy link
Contributor Author

Kunsi commented May 29, 2025

If that's okay with you, i'd like to merge this for now, and then i'll create a follow-up PR to merge the two frab exporters into one.

marksteward
marksteward reviewed May 29, 2025
View reviewed changes
Kunsi added 13 commits May 29, 2025 16:48
@Kunsi @marksteward
schedule_frab_json: remove comment about tracks
021881a
@Kunsi @marksteward
schedule_frab_json: use existing functions from schedule_xml
9796c60
@Kunsi @marksteward
move generation of frab-style json schedule to separate file
db068b0
@Kunsi @marksteward
export_db: adjust for changed frab xml endpoint and added frab json e…
7dce7ee 
…ndpoint
@Kunsi @marksteward
lineup_talk_redirect: frab xml has new function name
81e81c0
@Kunsi @marksteward
templates/schedule: mention frab xml and frab json export
d14045b
@Kunsi @marksteward
apps.schedule.schedule_json: fix some mistakes
75e4c5e
@Kunsi @marksteward
apps.schedule: rename schedule_{json,xml} to schedule_frab_{json,xml}
029b07a
@Kunsi @marksteward
apps.schedule.feeds: move /schedule/frab-{year}.{json,xml} to /schedu…
b99cf11 
…le/{year}.frab.{json,xml}
@Kunsi @marksteward
apps.schedule.schedule_frab_json: fix licence version
25a14f5
@Kunsi @marksteward
tests/test_{frab_export,schedule}: fix imports of apps.schedule.sched…
200d8bc 
…ule_frab_xml
@Kunsi @marksteward
Fix exports of schedules
fd06199 
The frab schedules were renamed, but the exporters were forgotten.
@Kunsi @marksteward
Static export for frab_json should be to {year}.frab.json
4b013e1
@marksteward marksteward force-pushed the kunsi-schedule-json-schema-compatible branch from ea4b05e to 4b013e1 Compare May 29, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksteward marksteward marksteward requested changes

@wlcx wlcx Awaiting requested review from wlcx

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kunsi @marksteward @wlcx